5718004666
69%

Ran 31 Jul 2023 06:09PM UTC

Jobs 0

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 5718004666

Build Type

push

github

Committed by

web-flow

Commit Message

Fail PR check if there are STOPSHIPs in any code (#639)

## Summary:

I shipped a STOPSHIP this week because I assumed this repo checked for them. It doesn't... but with this PR it will.  The check is done in a Github Action, so there won't be a test that fails locally, but any PR containing the word "STOPSHIP", will fail.

Example run where it finds issues:
<img width="1137" alt="image" src="https://github.com/Khan/perseus/assets/77138/7d8f8249-9859-4d59-908d-bd3e476a611b">


Issue: "none"

## Test plan:

Add a `STOPSHIP` to the code, push the branch. Github Action should fail. 
Remove the `STOPSHIP`, push the code, Github Action should pass!

Author: jeremywiebe

Reviewers: jeresig, #perseus, kevinbarabash, handeyeco

Required Reviewers:

Approved By: jeresig

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/639

Run Details

Source Files on build 5718004666

Detailed source file information is not available for this build.

Khan / perseus / 5718004666
69%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 5718004666

Khan / perseus / 5718004666 69%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on build 5718004666

Khan / perseus / 5718004666
69%

README BADGES
x