• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Khan / perseus / 5685440960
69%

Build:
DEFAULT BRANCH: main
Ran 27 Jul 2023 09:07PM UTC
Jobs 2
Files 525
Run time 13s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
5685440960

push

github

web-flow
Fix: Image widget editor fails to calculate image dimensions (#618)

## Summary:

This fixes an error where images where getting no size information. In addition it also adds preview information to the image editor pane so that content editors get better visibility into what's going on.

![image](https://github.com/Khan/perseus/assets/18454/d4c52e61-56ce-472d-a632-b01cb76a469e)

I think this gives us two ways to catch image problems before they get out to prod: better code and human intervention.

Issue: https://khanacademy.atlassian.net/browse/LC-821

## Test plan:
- Start storybook and play with the widget

Author: nixterrimus

Reviewers: nixterrimus, jeremywiebe

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ finish_coverage, ✅ Publish npm snapshot (ubuntu-latest, 16.x), ✅ Extract i18n strings (ubuntu-latest, 16.x), ✅ Check builds for changes in size (ubuntu-latest, 16.x), ✅ Lint, Typecheck, and Test (ubuntu-latest, 16.x), ✅ Cypress Coverage (ubuntu-latest, 16.x), ✅ Jest Coverage (ubuntu-latest, 16.x), ✅ Check for .changeset file (ubuntu-latest, 16.x), ✅ gerald

Pull Request URL: https://github.com/Khan/perseus/pull/618

7561 of 16366 branches covered (46.2%)

Branch coverage included in aggregate %.

3 of 48 new or added lines in 2 files covered. (6.25%)

69902 of 95900 relevant lines covered (72.89%)

717.4 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
6
76.45
-0.38% packages/perseus/src/util.ts
39
36.02
-2.56% packages/perseus-editor/src/widgets/image-editor.tsx
Subprojects
ID Flag name Job ID Ran Files Coverage
1 jest 5685440960.1 27 Jul 2023 09:17PM UTC 520
62.65
GitHub Action Run
2 cypress 5685440960.2 27 Jul 2023 09:07PM UTC 365
26.37
GitHub Action Run
Source Files on build 5685440960
  • Tree
  • List 525
  • Changed 18
  • Source Changed 0
  • Coverage Changed 18
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • 97d02dac on github
  • Prev Build on main (#5685421884)
  • Next Build on main (#5685467296)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc