549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346
84%
main: 81%

Ran 27 Jul 2023 12:34PM UTC

Jobs 1

Files 184

Run time 4s

Badge

Embed ▾

pending completion

cancel

Build # 549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346

Build Type

Pull #346

github

Committed by

rbino

Commit Message

push_rollout: rename max_errors_percentage to max_failure_percentage

This fixes two different problems: one, the plural "errors" was grammatically
incorrect, and the correct concept is "failure", since that's the term we use
for exceptions which result in a final state, while error is a possibly
temporary condition.
Add a migration to rename the field in the database and replace all occurrences
both in frontend and backend. The only remaining occurrence is in the docs, but
they have to be completely revamped anyway so it doesn't make sense to touch
them here.

Close #287

Signed-off-by: Riccardo Binetti <riccardo.binetti@secomind.com>

Pull Request Pull Request #346: push_rollout: rename max_errors_percentage to max_failure_percentage

Run Details

1393 of 1666 relevant lines covered (83.61%)

147.47 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346.1	27 Jul 2023 12:34PM UTC	184	83.61	GitHub Action Run

edgehog-device-manager / edgehog / 549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346
84%
main: 81%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346

edgehog-device-manager / edgehog / 549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346 84% main: 81%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346

edgehog-device-manager / edgehog / 549b8ff56cea5b3b780719f75d77ce97627ce69d-PR-346
84%
main: 81%

README BADGES
x