p11-glue / p11-kit / 5677391312

69%

push

github

Fix probing of C_GetInterface

`p11_dl_symbol (dl, "C_GetInterface")` uses dlsym() to find
C_GetInterface in the loaded pkcs11 module.  For legacy (pre-3.0) pkcs11
modules, C_GetInterface is not defined in the module.  But according to
the documentation of dlsym():

    The search performed by dlsym() is breadth first through the
    dependency tree of these shared objects.

So if a pkcs11 module links to libp11-kit.so, the C_GetInterface
implementation in libp11-kit.so itself will be found.  This
C_GetInterface will return the metadata of p11-kit-proxy.so, causing
"Refuse to load the p11-kit-proxy.so as a registered module".

To solve the issue, if p11_dl_symbol() returns the C_GetInterface in
libp11-kit.so itself, we should ignore it and continue trying
C_GetFunctionList.

12939 of 24619 branches covered (52.56%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

27207 of 33038 relevant lines covered (82.35%)

2140.72 hits per line