joshuaclayton / page_ez / 5670304602

100%

push

github

Fix bug related to subclassing and macro reuse (#41)

What?
=====

This updates the logic when inheriting from a PageEz::Page class to
reset visitors properly.

Previously, we checked to see if the first ancestor when inheriting was
a `PageEz::Page`. However, this behavior isn't actually correct, as
subclassing occurs in two fashions: from a library usage perspective,
and internally when nesting macros, e.g.

Library usage via traditional inheritance:

```ruby
class ApplicationPage < PageEz::Page
end

class Homepage < ApplicationPage
end
```

Nesting macros:

```ruby
has_one :list, "ul" do
  has_many_ordered :items, "li"
end
```

In both cases, the `inherited` hook gets called, but visitors should
only be reset via traditional inheritance and NOT by nesting macros.

This introduces a new class attribute, `nested_macro`, which defaults to
false and is set to true when generating an anonymous class for evaluation of
nested macros.

4 of 4 new or added lines in 1 file covered. (100.0%)

621 of 623 relevant lines covered (99.68%)

445.61 hits per line