skeema / skeema / 5662526119

92%

push

github

internal: pass linter.Options by pointer, not value

This commit adjusts all usage of linter.Options to be passed by pointer,
rather than by value. Two motivations for this:

* Efficiency: the struct contains 5 fields, and is passed to every single
  linter rule function call

* Mutability: if a linter rule needs to memoize some value to opts.RuleConfig,
  it may now do so cleanly. (Since opts.RuleConfig is a map and maps are
  reference types, technically this was already possible, but was bad/messy
  practice.) This may be useful for the collation linter proposed in #216,
  in order to detect the most common collation in a schema and memoize it in
  the RuleConfig.

41 of 41 new or added lines in 23 files covered. (100.0%)

9200 of 9871 relevant lines covered (93.2%)

1.11 hits per line