TexasDigitalLibrary / Vireo / 5649318894

57%

main: 59%

push

github

Issue 1842: Major Performance bottleneck in Workflow Step at significant XHRLoad cost.

The XHRLoad is processing too much data and can take as long as 4000ms.
This causes problems on the organization load pages.
This causes huge problems on less efficient browsers or low-resource/low-spec hardware (such as a phone).

This does not solve the primary problem with the Triptych and the Organizations, which still takes 1 to 2 seconds.
However, this stops the massive JS-time performance hit resulting from the XHRLoad of this data.

The `getAll()` is being called automatically, likely through weaver-ui-core.
There are no direct calls to this information via a getAll as far as I can tell.
This getAll is therefore not directly needed (but more testing and QA is needed to confirm this).

It would be ideal for there to be an option to tell weaver-ui-core to not auto-load.
Rather than trying to figure this out, I believe that a PR with reviews are the quickest and simplest way to confirm/deny this.
Just update the PR with a review documenting the method of disabling the auto-loading of the entire Workflow Step data.

After this change, the XHRLoad goes down from ~4000ms to ~1000ms.
Chrome based browsers do a good job of showing this performance statistic.

1017 of 2039 branches covered (49.88%)

Branch coverage included in aggregate %.

7672 of 13171 relevant lines covered (58.25%)

6.82 hits per line