os-autoinst / openQA / 2226

100%

Pull #668

travis-ci

<a href="https://github.com/os-autoinst/openQA/commit/<a class=hub.com/os-autoinst/openQA/commit/a179d941e8941d27a0be7ee72f4a2431dee53643">a179d941e<a href="https://github.com/os-autoinst/openQA/commit/a179d941e8941d27a0be7ee72f4a2431dee53643">&quot;&gt;Fix use of symlinked needle dirs from outside of basedir

This fixes a problem introduced with </a><a class="double-link" href="https://github.com/os-autoinst/openQA/commit/<a class="double-link" href="https://github.com/os-autoinst/openQA/commit/2b8ac3c859e6db1296fbf7f6ff71d0306d9501e8">2b8ac3c85</a>">2b8ac3c85</a><a href="https://github.com/os-autoinst/openQA/commit/a179d941e8941d27a0be7ee72f4a2431dee53643">.
The check for the needledir has been moved where an external file path is used
coming from a REST request where additional care should be taken to ensure a
valid and secure directory. For a &quot;local&quot; definition of the needledir the
check was removed changing the behaviour back to the old way supporting
symlinked needle dirs, e.g. when /local/needles is symlinked into
/var/lib/openqa/share/tests/... instead of being a real subdirectory.

For the &quot;new&quot; feature of an external definition of needle dirs test cases are
(still) missing and should be added before another related change is done.

Fixes gh #667.

3 of 3 new or added lines in 1 file covered. (100.0%)

2883 of 4475 relevant lines covered (64.42%)

55.49 hits per line