Qiskit / qiskit-terra / 5616085257

87%

push

github

Add `Expr` support to OpenQASM 3 exporter (#10408)

* Add `Expr` support to OpenQASM 3 exporter

This adds support for `Expr` nodes in `condition` fields and
`SwitchCaseOp.target`.  The general `c_if` condition checking is lifted
into an `Expr` node as part of the OQ3 export, so the form of them
automatically becomes like the new-style outputs, depending on how
`expr.lift_legacy_condition` chooses to raise them to `Expr` nodes.

As part of the refactor of the `Expression` subtree of the temporary
AST, I removed `SubroutineCall`.  Its definition was severely
out-of-date (a form from before even the initial arXiv draft), where it
was statement-like instead of expression-like.  There is currently no
support in Qiskit for representing these sorts of subroutines properly,
and the OQ3 exporter would produce invalid OQ3 if it encountered
something that it thought should be a a subroutine call.  This commit
fixes that bug, correctly raising an exception that non-unitary
instructions are not yet supported for export.

This commit also removes the special casing from the `CXGate` into the
exporter itself; it was more convenient in the new structure of some
internal components, and it's a data model we don't want to support
anyway.

* Use `IntegerLiteral` for `Uint` values

This is what the QSS stack expects (they don't like bitstring literals
in expressions yet), and is more in line with what we used to do anyway.

* Fix quotes

* Add test of no spurious casts

166 of 166 new or added lines in 3 files covered. (100.0%)

72845 of 84780 relevant lines covered (85.92%)

58883.11 hits per line