Qiskit / qiskit-terra / 5596811776

86%

main: 87%

push

github

Remove method `qasm` from `Instruction` and all of its subclasses (#10399)

* Deprecate Instruction.qasm

* Deprecate all `qasm` methods for Instruction and subclasses.
* Move code for generating OpenQASM 2 strings to `QuantumCircuit`.
* Test that deprecation warnings are raised.
* Add release note.

* Fix lint errors

* Fix still more lint errors

* Revert replacing old code with new inside deprecated method

In x.py in class C3SXGate the method `qasm` has been deprecated. It's
ok and simpler to deprecated code in this method. The two deprecated
pieces will be removed together.

* Revert formatting change

`for (param, value) in ...` was replaced with `for param, value in ...`.
This commit reverts that change.

* Remove method has_qasm2 from HamiltonianGate and simplify a deprecation message

* The method has_qasm2 was added in a previous commit (not in main). It is
  removed with this commit.

* An additional message was added to the deprecation warning for HamiltonianGate.qasm.
  It is removed with this commit

* A test has been updated to reflect these changes.

* Simplify hack for name c3sqrtx

c3sqrtx is the name we need to use with OpenQASM2 for qiskit's c3sx.
This makes the hack a bit less wordy and perhaps more palatble. The gate's
name is no longer changed before calling a function on it, then changed back.

* Remove intermediate variable introduced with this 10399

PR 10399 (not merged) changed a method call inside a Python f-string statement
into a call outside, introducing a variable, and use of that variable inside the
f-string. This commit makes a more minimal change.

Now we only replace the method call with an ordinary function call.

* Restore blank line inadvertently removed

* Factor out creation of "custom" qasm2 operation statement

* Remove addition_message from deprecation in x.py

* Update documentation for error thrown by QuantumCircuit.qasm

The docstring states that a CircuitError is raised if a gate cannot be converted to ... (continued)

29 of 29 new or added lines in 4 files covered. (100.0%)

72697 of 84468 relevant lines covered (86.06%)

58801.32 hits per line