5579680709
100%
main: 99%

Ran 17 Jul 2023 07:17PM UTC

Jobs 1

Files 14

Run time 1s

Badge

Embed ▾

pending completion

Build # 5579680709

Build Type

push

github

Committed by

ghukill

Commit Message

Update type hints in helpers.write_timdex_records_to_json

Why these changes are being introduced:
* After some refactoring in 07/2022 that added an iterator pattern to Transformer, it looks as though downstream type hints were not updated.
* While this did not affect runtime, it made reading the code somewhat confusing to someone new to the codebase.

How this addresses that need:
* Update the `records` input argument of `helpers.write_timdex_records_to_json()` from `Iterator[TimdexRecord]` to `Transformer`
* rename `records` to `transformer_instance`, matching variable names from calling `cli.py`
* Add explicit `TimdexRecord` type hint for result of `next(transformer_instance)`

Side effects of this change:
* None

Relevant ticket(s):
* None

Run Details

1023 of 1026 relevant lines covered (99.71%)

1.0 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5579680709.1	17 Jul 2023 07:17PM UTC	0	99.71	GitHub Action Run

Source Files on build 5579680709

Detailed source file information is not available for this build.

MITLibraries / transmogrifier / 5579680709
100%
main: 99%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5579680709

MITLibraries / transmogrifier / 5579680709 100% main: 99%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5579680709

MITLibraries / transmogrifier / 5579680709
100%
main: 99%

README BADGES
x