lmc-eu / spirit-design-system / 5573934419

LAST BUILD BRANCH: fix/DS-2239-scrollview-bug-fix
DEFAULT BRANCH: main
Ran
Jobs 3
Files 7
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5573934419

push

github

crishpeen 
BREAKING CHANGE(web-react): Remove Header deprecations #DS-651

 ## Migration Guide

Instead of `HeaderModern`, now use `Header` and its structure.

The most notable change is that the mobile and desktop navigation
are now separate components that cannot be nested:

- `Header`
- `HeaderDialog`

Formerly, the desktop dialog (holding the site navigation) was
a responsive CSS modification of a shared HTML code. With the
new `Header` and `HeaderDialog`, each component has its own
instance of the navigation, i.e. the navigation code is duplicated.
This is because `HeaderDialog` will become an independent
component in the future.

You may need to take additional measures so your SEO is not
affected by the duplicate HTML code of the navigation.

The old components in `Header` can be roughly mapped onto the
new subcomponents like this:

- `NavbarToggler` → `HeaderMobileOnlyActions`
- `Navbar` → removed without a replacement
- `Navbar variant="dialog"` → `HeaderDialog`, stands outside `Header`
- `NavbarClose` → removed without a replacement
- `HeaderActions` → `HeaderDesktopOnlyActions`
- `HeaderBackdrop` → removed without a replacement
- `Nav` → `HeaderNav`
- `NavItem` → `HeaderNavItem`
- `NavLink` → `HeaderLink`
- `Header__text` → removed without a replacement

Please refer back to these instructions or reach out to our team
if you encounter any issues during migration.

224 of 232 relevant lines covered (96.55%)

100.28 hits per line

Subprojects
ID Flag name Job ID Ran Files Coverage
1 unit-tests-PHP-7.4 5573934419.1 7
96.55
 GitHub Action Run
2 unit-tests-PHP-8.1 5573934419.2 7
96.55
 GitHub Action Run
3 unit-tests-PHP-8.2 5573934419.3 7
96.55
 GitHub Action Run
Source Files on build 5573934419