5546583804-1
95%

Ran 13 Jul 2023 06:37PM UTC

Jobs 7

Files 47

Run time 2s

Badge

Embed ▾

pending completion

Build # 5546583804-1

Build Type

push

github

Committed by

web-flow

Commit Message

fix(proxy-wasm) expect the 'NGX_WASM_HOST_PROPERTY_NAMESPACE' macro unquoted

This is not really a bug on our end, but Nginx's build system
doesn't like `--with-cc-opt` entries that feature double-quoted variables
as in `"--with-cc-opt=\"-DNGX_WASM_HOST_PROPERTY_NAMESPACE=\\\"kong\\\"\""`.

This _does_ work when expanding the flag and building our module,
but the compilation of Nginx itself later fails with:

```
src/core/nginx.c:456:49: note: in expansion of macro 'NGX_CONFIGURE'
  456 |         ngx_write_stderr("configure arguments:" NGX_CONFIGURE NGX_LINEFEED);
      |                                                 ^~~~~~~~~~~~~
src/core/nginx.c:456:25: note: to match this '('
  456 |         ngx_write_stderr("configure arguments:" NGX_CONFIGURE NGX_LINEFEED);
      |                         ^
```

So let's just play nice and drop the quotes on our end.

From #349

Run Details

7515 of 8272 relevant lines covered (90.85%)

17625.59 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	unit-ngx_1.25.1-wasmtime-ssl-debug-hup-static - 5546583804-1.1	13 Jul 2023 06:50PM UTC	90.08	GitHub Action Run
2	unit-openresty_1.21.4.1-wasmtime-ssl-debug-no_hup-static - 5546583804-1.2	13 Jul 2023 06:51PM UTC	90.35	GitHub Action Run
3	unit-ngx_1.25.1-wasmer-ssl-debug-no_hup-static - 5546583804-1.3	13 Jul 2023 06:39PM UTC	90.45	GitHub Action Run
4	unit-ngx_1.25.1-wasmer-no_ssl-no_debug-no_hup-static - 5546583804-1.4	13 Jul 2023 06:37PM UTC	89.27	GitHub Action Run
5	unit-ngx_1.25.1-wasmer-ssl-no_debug-no_hup-static - 5546583804-1.5	13 Jul 2023 06:39PM UTC	89.72	GitHub Action Run
6	unit-ngx_1.21.6-wasmer-ssl-debug-no_hup-static - 5546583804-1.6	13 Jul 2023 06:38PM UTC	90.42	GitHub Action Run
7	unit-ngx_1.25.1-v8-ssl-debug-no_hup-static - 5546583804-1.7	13 Jul 2023 06:45PM UTC	90.85	GitHub Action Run

Source Files on build 5546583804-1

Detailed source file information is not available for this build.

Kong / ngx_wasm_module / 5546583804-1
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5546583804-1

Kong / ngx_wasm_module / 5546583804-1 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5546583804-1

Kong / ngx_wasm_module / 5546583804-1
95%

README BADGES
x