5524886738-1
95%

Ran 11 Jul 2023 09:19PM UTC

Jobs 8

Files 47

Run time 3s

Badge

Embed ▾

pending completion

Build # 5524886738-1

Build Type

push

github

Committed by

web-flow

Commit Message

fix(wasm) fix a macos segfault caused by swapping module handlers

When ngx_wasm_module is compiled as a dynamic module along
ngx_lua_module, it might need to swap their positions in the `cycle->modules`
array so that initialization and execution run properly.

However, the modules positions in `cycle->modules` are being changed
as the array is iterated.

More specifically, the following line

    (*ctx)[cf->cycle->modules[i]->ctx_index] = m->create_conf(cf);

attempted to assign the new configuration to `(*ctx)` when the
expression `cf->cycle->modules[i]->ctx_index` is not guaranteed to
be valid since `create_conf` will potentially change the position of
modules within `cycle->modules`, making `i` outdated.

This behavior is fixed by assigning `cycle->modules[i]` to a variable and
referencing the variable instead of `cycle->modules[i]` directly.

From  #344

Run Details

7519 of 8276 relevant lines covered (90.85%)

15470.06 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	unit-ngx_1.21.6-wasmer-ssl-debug-no_hup- - 5524886738-1.1	11 Jul 2023 09:21PM UTC	90.42	GitHub Action Run
2	unit-ngx_1.25.1-wasmer-no_ssl-no_debug-no_hup- - 5524886738-1.2	11 Jul 2023 09:19PM UTC	89.27	GitHub Action Run
3	unit-ngx_1.25.1-wasmtime-ssl-debug-hup- - 5524886738-1.3	11 Jul 2023 09:35PM UTC	90.06	GitHub Action Run
4	unit-openresty_1.21.4.1-wasmtime-ssl-debug-no_hup- - 5524886738-1.4	11 Jul 2023 09:36PM UTC	90.33	GitHub Action Run
5	unit-ngx_1.25.1-wasmer-ssl-no_debug-no_hup-static - 5524886738-1.5	11 Jul 2023 09:20PM UTC	89.72	GitHub Action Run
6	unit-ngx_1.25.1-wasmer-ssl-debug-no_hup-static - 5524886738-1.6	11 Jul 2023 09:20PM UTC	90.45	GitHub Action Run
7	unit-openresty_1.21.4.1-wasmtime-ssl-debug-no_hup-dynamic - 5524886738-1.7	11 Jul 2023 09:35PM UTC	90.34	GitHub Action Run
8	unit-ngx_1.25.1-v8-ssl-debug-no_hup- - 5524886738-1.8	11 Jul 2023 09:27PM UTC	90.85	GitHub Action Run

Source Files on build 5524886738-1

Detailed source file information is not available for this build.

Kong / ngx_wasm_module / 5524886738-1
95%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5524886738-1

Kong / ngx_wasm_module / 5524886738-1 95%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5524886738-1

Kong / ngx_wasm_module / 5524886738-1
95%

README BADGES
x