libcgroup / libcgroup / 5488214083

56%

Build Type

push

github

Committed by drakenclimber

Commit Message

tools/cgxset: fix unused value in main

Fix unused value, reported by the Coverity tool:

CID 320876 (#1 of 1): Unused value (UNUSED_VALUE)assigned_value:
Assigning value 0 to ret here, but that stored value is overwritten
before it can be used.

If the mapping from v1->v2 and vice versa fail, with -i
(ignore-unmappable) set, ret is set to zero and is immediately
over-written, re-arrange the check, and adjust the commentary to avoid
clobbering ret, by taking the error path when -i is unset or else
continuing when set, skipping to set ret to zero.

Suggested-by: Tom Hromatka <tom.hromatka@oracle.com>
Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Coverage Stats

1 of 2 new or added lines in 1 file covered. (50.0%)

10 existing lines in 2 files now uncovered.

5520 of 9403 relevant lines covered (58.7%)

832.52 hits per line