5445997482
56%

Ran 03 Jul 2023 03:06PM UTC

Jobs 6

Files 28

Run time 2s

Badge

Embed ▾

pending completion

Build # 5445997482

Build Type

push

github

Committed by

drakenclimber

Commit Message

tools/cgclassify: fix controller overflow array range

Fix out-of-bounds write issue, reported by Coverity tool:

CID 321270 (#1 of 1): Out-of-bounds write (OVERRUN)47. overrun-local:
Overrunning array info of 16 4128-byte elements at element index 16
(byte offset 70175) using index i (which evaluates to 16).

MAX_MNT_ELEMENTS is an array that's allocated for array parsing and
populating the mount points, as per Linux Kernel, this can't be above
16 and it works fine while checking for index < MAX_MNT_ELEMENTS, but
in this case, we rely on the mount point name to be empty ('\0'), since
allowed maximum mount points are 16, increase the allocation index to
17 for the info structure, to accommodate 16 controllers, but that is
unlikely.

Signed-off-by: Kamalesh Babulal <kamalesh.babulal@oracle.com>
Signed-off-by: Tom Hromatka <tom.hromatka@oracle.com>

Coverage Stats

5555 of 9401 relevant lines covered (59.09%)

1375.7 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	Unit Tests - 5445997482.1	03 Jul 2023 03:06PM UTC	11.08	GitHub Action Run
2	Cgroup v1/v2 Functional Tests - 5445997482.2	03 Jul 2023 03:11PM UTC	53.36	GitHub Action Run
3	Cgroup v1 Functional Tests - 5445997482.3	03 Jul 2023 03:10PM UTC	44.88	GitHub Action Run
4	Cgroup v2 Functional Tests - hybrid - 5445997482.4	03 Jul 2023 03:56PM UTC	52.2	GitHub Action Run
5	Cgroup v2 Functional Tests - unified - 5445997482.5	03 Jul 2023 04:02PM UTC	51.14	GitHub Action Run
6	Cgroup v2 Functional Tests - legacy - 5445997482.6	03 Jul 2023 04:13PM UTC	51.34	GitHub Action Run

Source Files on build 5445997482

Detailed source file information is not available for this build.

libcgroup / libcgroup / 5445997482
56%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5445997482

libcgroup / libcgroup / 5445997482 56%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5445997482

libcgroup / libcgroup / 5445997482
56%

README BADGES
x