• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Valloric / ycmd / 1919
94%

Build:
DEFAULT BRANCH: master
Ran 08 May 2016 07:08AM UTC
Jobs 1
Files 40
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1919

push

travis-ci

homu
Auto merge of #482 - vheon:fix-no-hmac-header-on-big-request, r=micbou

[READY] Return a proper response when the request is too big.

We have a hard limit on the size of the request that ycmd can handle that is set to 1Mb. This is dictated by Bottle and there is no way around it.

#### Why is this a problem:

When a client makes a request greater than 1Mb Bottle returns an error that is not generated by us and thus it is not a json response, but an html one, and it doesn't contain the HMAC header which causes  errors like #476.

For now I've pushed only the failing test. Once I see it fail on Travis I will push the fix.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/482)
<!-- Reviewable:end -->

1 of 1 new or added line in 1 file covered. (100.0%)

3059 of 3603 relevant lines covered (84.9%)

0.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1919.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true) 08 May 2016 07:08AM UTC 0
84.9
Travis Job 1919.1
Source Files on build 1919
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1919
  • 76dd7b9e on github
  • Prev Build on master (#1901)
  • Next Build on master (#1923)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc