sds / haml-lint / 5339595941

97%

push

github

Enable RuboCop auto-correction (#346)

* Fix displayed requirement for Ruby in README for 2.6+

* Changes to keep empty trailing lines in source_lines
This makes some function look more correct, because before, they assumed no trailing empty lines, which is not intuitive and feels weird in a context of autocorrection.

* Fix wrong handling of literal \n in extract_interpolated_values
Previous version would treat escaped \n as regular \n

* Fix a test that was kinda invalid haml
It's valid haml, but the generated Ruby would raise a SyntaxError

* Moving a test, will make next commit more readable

* Refactor HAML_LINT_RUBOCOP_CONF and config_file test
They only checked that RuboCop received a flag, the new tests actually checks that linting results change
Needed due to future changes for the new RuboCop Linter, which will set the config directly in RuboCop, not using a flag

* Make Haml::Error's wrapper include file name

* Add debug mode to display more info in errors

* Remove unused option in runner_spec
The runner is stubbed to forcefully return the specified files. Passing them as options (and only sometimes) is more confusing than anything else.

* Make Linter#run turn internal exceptions into lints
So HamlLint can keep working when it encouters an internal error
Also add Linter#run_or_raise for tests. Makes errors easier to investigate when testing by failing quickly.

* Add ERB pre-processing of config
Will be needed to better handle multiple RuboCop versions which add and rename cops

* Add basic autocorrect machinery

* Upgrade minimum Rubocop to 1.0
Also disable Style/StringConcatenation since it often generates code that doesn't feel better to me

* Add autocorrection for RuboCop

* Tests for the RuboCop autocorrect system

* Add appraisals for different Rubocop versions

* Fix autocorrection with config skip_frontmatter: true

* Add forced_rubocop_config to avoid some very weird resulting HAML
... (continued)

921 of 1000 new or added lines in 44 files covered. (92.1%)

2585 of 2672 relevant lines covered (96.74%)

36064.09 hits per line