438
94%

Ran 20 Mar 2014 09:43AM UTC

Jobs 14

Files 9

Run time 13min

Badge

Embed ▾

pending completion

Build # 438

Build Type

Pull #729

travis-ci

Committed by

doggydogworld

Commit Message

Adds a filter function to Builder and config.
If this is set, then Strategy will call this function before it even
considers passing it on to request_call, options_call, etc.
If the return value is false, then Strategy will call the app instead of
handling the call itself.

The purpose of this patch is to allow apps to filter calls to OmniAuth.
For example, if a user is already logged in and requests /auth/:provider
(either accidentally or out of mischief), then the app may want to prevent
OmniAuth from handling it and just spit out an error.

There may be more efficient ways to implement this, but I just wanted
to initiate a conversation.

Pull Request Pull Request #729: Adds a filter function

Run Details

501 of 533 relevant lines covered (94.0%)

259.66 hits per line

Uncovered Existing Lines

Lines	Coverage	File
2	100.0	lib/omniauth/strategy.rb
2	100.0	lib/omniauth/builder.rb
2	100.0	lib/omniauth.rb

Jobs

ID	Job ID	Ran	Coverage
3	438.3 (1.9.3, Gemfile)	20 Mar 2014 09:44AM UTC	92.94	Travis Job 438.3
4	438.4 (2.0.0, Gemfile)	20 Mar 2014 09:43AM UTC	92.94	Travis Job 438.4
5	438.5 (2.1.0, Gemfile)	20 Mar 2014 09:44AM UTC	92.94	Travis Job 438.5
6	438.6 (rbx-2, Gemfile)	20 Mar 2014 09:47AM UTC	98.4	Travis Job 438.6
7	438.7 (ruby-head, Gemfile)	20 Mar 2014 09:46AM UTC	92.94	Travis Job 438.7
9	438.9 (1.9.2, Gemfile.rack-1.3.x)	20 Mar 2014 09:47AM UTC	93.35	Travis Job 438.9
10	438.10 (1.9.3, Gemfile.rack-1.3.x)	20 Mar 2014 09:46AM UTC	93.35	Travis Job 438.10
11	438.11 (2.0.0, Gemfile.rack-1.3.x)	20 Mar 2014 09:47AM UTC	93.35	Travis Job 438.11
12	438.12 (2.1.0, Gemfile.rack-1.3.x)	20 Mar 2014 09:48AM UTC	93.35	Travis Job 438.12
13	438.13 (rbx-2, Gemfile.rack-1.3.x)	20 Mar 2014 09:49AM UTC	98.8	Travis Job 438.13
14	438.14 (ruby-head, Gemfile.rack-1.3.x)	20 Mar 2014 09:49AM UTC	93.35	Travis Job 438.14
17	438.17 (jruby-19mode, JRUBY_OPTS="$JRUBY_OPTS --debug", Gemfile)	20 Mar 2014 09:51AM UTC	93.12	Travis Job 438.17
18	438.18 (jruby-19mode, JRUBY_OPTS="$JRUBY_OPTS --debug", Gemfile.rack-1.3.x)	20 Mar 2014 09:52AM UTC	93.52	Travis Job 438.18
19	438.19 (jruby-head, JRUBY_OPTS="$JRUBY_OPTS --debug", Gemfile)	20 Mar 2014 09:57AM UTC	93.12	Travis Job 438.19

Source Files on build 438

Detailed source file information is not available for this build.

intridea / omniauth / 438
94%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 438

intridea / omniauth / 438 94%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 438

intridea / omniauth / 438
94%

README BADGES
x