tarantool / tarantool / 5288041851

86%

master: 88%

push

github

core: fix wal saving an empty xlog during startup failure

After the commit a392eb765c12 ("box: destroy its modules even if box.cfg
not done") wal_free() on exit is called even if box.cfg() isn't finished
yet, and thus wal isn't yet enabled. This leads to a bug when wal would
unconditionally write a 00...0.xlog regardless of the actual xlog
directory contents or the actual vclock.

Let's fix this by not writing an empty xlog on exit if wal writer's
vclock is zero. It means the writer either wasn't enabled yet, or was
enabled, but hasn't written anything. In both cases writing the empty
xlog is extraneous.

Closes #8704

NO_DOC=bugfix

(cherry picked from commit f78908c98)

62108 of 114106 branches covered (54.43%)

93108 of 108622 relevant lines covered (85.72%)

2872302.97 hits per line