5287582134
65%

Ran 16 Jun 2023 08:03AM UTC

Jobs 1

Files 105

Run time 2s

Badge

Embed ▾

Committed 16 Jun 2023 08:03AM UTC coverage: 66.314%. Remained the same

Build # 5287582134

Build Type

push

github

Committed by

web-flow

Commit Message

fix: duplicate identity error on update user (#1141)

## What kind of change does this PR introduce?
* When updating a user's email or phone number, if the user previously
did not have an email or phone number associated to their account,
gotrue will create an new identity for it. However, subsequent attempts
to update the user's email or phone number will result in gotrue
attempting to create the same identity again. This results in postgres
returning a unique constraint violation.

For example, assuming that the user signed up with email + password
initially:

```bash
# this request will create a phone identity and send an OTP to the user
curl -X PUT "http://localhost:9999/user" -H "Authorization: Bearer <access_token>" -H "Content-Type: application/json" -d '{"phone": "123456789"}'

# this request will return a "duplicate key value violates unique constraint" error because gotrue attempts to create the same phone identity
curl -X PUT "http://localhost:9999/user" -H "Authorization: Bearer <access_token>" -H "Content-Type: application/json" -d '{"phone": "123456789"}'
```

* ~This PR attempts to fix this issue by only creating the identity if
the user's `phone` or `phone_change` columns are empty.~

Run Details

7026 of 10595 relevant lines covered (66.31%)

47.43 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	5287582134.1	16 Jun 2023 08:03AM UTC	0	66.31	GitHub Action Run

Source Files on build 5287582134

Detailed source file information is not available for this build.

supabase / gotrue / 5287582134
65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5287582134

supabase / gotrue / 5287582134 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5287582134

supabase / gotrue / 5287582134
65%

README BADGES
x