jlfwong / speedscope / 5276415483

44%

master: 47%

push

github

fix pprof defaultSampleType (#424)

Fixes #415

* Interprets pprof's defaultSampleType as an index into the string table [as documented in the proto](https://github.com/jlfwong/speedscope/blob/0414c2f61/src/import/profile.proto#L85), not as an index into the sample types repeated-field. This allows parsing to succeed when the string-table index is not a valid sampleTypes index, which is common on allocation profiles.
* Update the pprof snapshot. This is necessarily because we were previously interpreting an empty defaultSampleType as truthy-but-zero when long.js is present, ie: the first sample-type. But Speedscope-in-the-browser doesn't seem to include long.js, so our tests were disagreeing with in-browser behavior. With this PR, that should be fixed.

1098 of 2707 branches covered (40.56%)

Branch coverage included in aggregate %.

2530 of 5909 relevant lines covered (42.82%)

6652.51 hits per line