• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

tarantool / tarantool / 5276304508
88%

Build:
DEFAULT BRANCH: master
Ran 15 Jun 2023 08:13AM UTC
Jobs 1
Files 487
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

15 Jun 2023 08:03AM UTC coverage: 85.909% (+0.04%) from 85.874%
5276304508

push

github

locker
xrow: ignore unknown IPROTO keys on decode

The xrow_decode_* functions are written in such a way that they ignore
unknown IPROTO keys. This is required for connectivity between different
Tarantool version. However, there's bug in the code connected with the
value type checking: we fail if the key is >= iproto_key_MAX. This
worked fine as long as we added new IPROTO keys in the middle of the key
space, without bumping iproto_key_MAX, but this assumption broke when we
added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that
IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on
connect. Let's fix the value type check and add some tests.

Notes:
 - xrow_decode_heartbeat turns out to be unused. Drop it.
 - Fix the net.box helpers response_body_decode and netbox_decode_table
   to handle unknown keys and empty body. This is needed to properly
   decode a response to an injection in tests.
 - Testing unknown keys in replication requests would be complicated.
   Instead we add a bunch of unit tests.
 - Convert the xrow unit test to TAP.

Closes #8745

NO_DOC=bug fix

63217 of 115658 branches covered (54.66%)

94841 of 110397 relevant lines covered (85.91%)

2851341.52 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5276304508.1 15 Jun 2023 08:13AM UTC 0
85.91
GitHub Action Run
Source Files on build 5276304508
Detailed source file information is not available for this build.
  • Back to Repo
  • ee0660b8 on github
  • Prev Build on master (#5258835868)
  • Next Build on master (#5278224273)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc