tarantool / tarantool / 5276304508

88%

push

github

xrow: ignore unknown IPROTO keys on decode

The xrow_decode_* functions are written in such a way that they ignore
unknown IPROTO keys. This is required for connectivity between different
Tarantool version. However, there's bug in the code connected with the
value type checking: we fail if the key is >= iproto_key_MAX. This
worked fine as long as we added new IPROTO keys in the middle of the key
space, without bumping iproto_key_MAX, but this assumption broke when we
added IPROTO_AUTH_TYPE. The issue is exacerbated by the fact that
IPROTO_AUTH_TYPE is used by IPROTO_ID, which is sent unconditionally on
connect. Let's fix the value type check and add some tests.

Notes:
 - xrow_decode_heartbeat turns out to be unused. Drop it.
 - Fix the net.box helpers response_body_decode and netbox_decode_table
   to handle unknown keys and empty body. This is needed to properly
   decode a response to an injection in tests.
 - Testing unknown keys in replication requests would be complicated.
   Instead we add a bunch of unit tests.
 - Convert the xrow unit test to TAP.

Closes #8745

NO_DOC=bug fix

63217 of 115658 branches covered (54.66%)

94841 of 110397 relevant lines covered (85.91%)

2851341.52 hits per line