openconfig / ygot / 5261585609

89%

push

github

Uncompressed ordered map tests for ytypes (#873)

* Add support for ending iteration of subtrees in `ForEachDataField`

* Try adding stringer

* install stringer

* fix comment

* fix enum name

* Add `DiffWithAtomic` to support creating Atomic Notifications.

When comparing two GoStructs where a YANG `ordered-by user` list is
involved, it is not possible using a single Notification to represent
the diff such that the Notification can do the following:
1. update a gNMI cache correctly with the atomic notification.
2. unmarshal the notification to the `orig` to get back the `modified`
   GoStruct.

This function achieves this functionality, sharing the underlying
implementation with Diff, where a disclaimer has been added to the doc
comment.

Other helpers have been created as well to be shared with
`TogNMINotifications`.

Other changes:
- `TogNMINotifications` has been changed to follow the same convention of
  putting the non-atomic Notification as the first message instead of
  the last. The reason is that current code MAY be using `notifs[0]` and
  I don't want to break that, and this also seems slightly better from a
  usability perspective.

* Fix bug when IgnoreAdditions option is turned on

* Add tests for PopulateDefaults for ordered maps

* Move TestTogNMINotifications's ordered map tests to exported tests

* Export ConstructJSON ordered map test

* Export remaining ordered map tests

* lint

* Initial tests for uncompressed structs with ordered maps.

* Remove more dead test code

* Uncompressed ordered map test on PopulateDefaults

* Uncompressed GoStruct tests in mostly `ygot` package.

* Simplified `UnmarshalSetRequest` to always unmarshal w/r to the root
  node. This allows atomic Notifications to be deleted correctly.

* Uncompressed ordered map tests for ytypes

* Move TestTogNMINotifications's ordered map tests to exported tests (#867)

* Move TestTogNMINotifications's ordere... (continued)

43 of 43 new or added lines in 11 files covered. (100.0%)

13182 of 14706 relevant lines covered (89.64%)

506.94 hits per line