uber / cadence / 0188b6ba-6aaf-4739-8b30-52eaead5800c
72%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 657
Run time 10s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 57.204% (-0.01%) from 57.217%
0188b6ba-6aaf-4739-8b30-52eaead5800c

push

buildkite

web-flow 
Bugfix/isolation groups domain drains (#5315)

What changed?
Fixes several bugs in the domain isolation-group handling which wasn't tested properly in replication it notably:

Fixes the problem of upserting configuration from the inactive region, which was previously would error
Fixes the problem of replication of configuration, which was entirely not working
Refactors the domain controller by splitting out this functionality into its own, much simpler function rather than continuing to overload the already incomprehensible domain controller.
Why?

How did you test it?

cadence --env docstore-prod11 --proxy_region dca admin isolation-groups get-domain --domain cadence-canary-global
Isolation Groups State
asdf5            Drained
asfd             Drained
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region dca admin isolation-groups update-domain --domain cadence-canary-global  --remove-all-drains
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region dca admin isolation-groups get-domain --domain cadence-canary-global
-- No groups found --
-------------------------------------------------------------------------------------------------------------------------------------------------------------
~ » cadence --env an-env --proxy_region phx admin isolation-groups get-domain --domain cadence-canary-global
-- No groups found --
Potential risks

141 of 141 new or added lines in 5 files covered. (100.0%)

86988 of 152065 relevant lines covered (57.2%)

2482.57 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
2
81.86
 -0.72% common/domain/replicationTaskExecutor.go
5
40.26
 -0.05% common/types/shared.go
39
76.91
 -2.55% common/domain/handler.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
81.86
 -0.72% common/domain/replicationTaskExecutor.go
2
38.1
 -0.25% client/history/client.go
2
45.3
 -0.42% client/history/metricClient.go
2
83.54
 -1.27% common/membership/hashring.go
2
81.58
 -1.32% common/peerprovider/ringpopprovider/config.go
2
50.65
 -2.6% common/persistence/sql/common.go
2
83.33
 -2.56% common/persistence/sql/sqlplugin/mysql/db.go
2
89.64
 0.0% common/task/weightedRoundRobinTaskScheduler.go
2
21.97
 -0.3% common/types/mapper/thrift/admin.go
2
90.29
 0.0% service/matching/matcher.go
3
49.04
 -0.58% common/log/tag/tags.go
3
58.66
 -0.41% common/persistence/dataManagerInterfaces.go
4
45.35
 -0.79% common/types/history.go
4
60.24
 -0.11% service/frontend/workflowHandler.go
4
47.15
 -0.26% service/history/handler.go
5
57.0
 -0.44% common/persistence/persistenceMetricClients.go
5
84.54
 -3.09% common/task/fifoTaskScheduler.go
5
83.74
 -2.03% service/matching/taskReader.go
13
68.48
 -0.45% service/history/historyEngine.go
20
70.57
 -5.71% service/history/task/task_util.go
Jobs
ID Job ID Ran Files Coverage
1 0188b6ba-6aaf-4739-8b30-52eaead5800c.1 657
57.2
Source Files on build 0188b6ba-6aaf-4739-8b30-52eaead5800c