openconfig / ygot / 5248409333

89%

push

github

Add support for ending iteration of subtrees by new `ForEachDataField2` (#862)

* Add support for ending iteration of subtrees in `ForEachDataField`

* Try adding stringer

* install stringer

* fix comment

* fix enum name

* Improve comments

* Add `DiffWithAtomic` to support creating Atomic Notifications. (#864)

* Add `DiffWithAtomic` to support creating Atomic Notifications.

When comparing two GoStructs where a YANG `ordered-by user` list is
involved, it is not possible using a single Notification to represent
the diff such that the Notification can do the following:
1. update a gNMI cache correctly with the atomic notification.
2. unmarshal the notification to the `orig` to get back the `modified`
   GoStruct.

This function achieves this functionality, sharing the underlying
implementation with Diff, where a disclaimer has been added to the doc
comment.

Other helpers have been created as well to be shared with
`TogNMINotifications`.

Other changes:
- `TogNMINotifications` has been changed to follow the same convention of
  putting the non-atomic Notification as the first message instead of
  the last. The reason is that current code MAY be using `notifs[0]` and
  I don't want to break that, and this also seems slightly better from a
  usability perspective.

* Fix bug when IgnoreAdditions option is turned on

184 of 184 new or added lines in 4 files covered. (100.0%)

13200 of 14724 relevant lines covered (89.65%)

498.03 hits per line