macbre / phantomas / 5243714709

89%

push

github

Use the new head{-less,-full} mode for Chrome (#1281)

* Use the new head{-less,-full} mode for Chrome

Resolves #1279

See https://developer.chrome.com/articles/new-headless/

* nginx: make /favicon.ico return 204 No Content

The default 404 response is served as an HTML which skews our asserted metrics.

$ curl 0.0.0.0:8888/favicon.ico -I
HTTP/1.1 204 No Content
Date: Fri, 09 Jun 2023 18:41:05 GMT
Connection: keep-alive
Server: nginx

* Tests: update the assertions to include the requests made to /favicon.ico

* test/integration.test.js: add some typing and be less strict when asserting offenders

* Update doc links

* More metrics assertions updated

* test/integration-spec.yaml: more metrics updated

* browser: make sure to default the viewport to a specific size

460 of 537 branches covered (85.66%)

Branch coverage included in aggregate %.

1282 of 1425 relevant lines covered (89.96%)

228.46 hits per line