synapsecns / synapse-contracts / 5192356005

13%

push

github

feat: Private pools (#232)

* init private pool

* swap in private pool

* factory for private pools

* salt on factory deploy

* private pool add liquidity

* fix swap for fixed price curve

* balance checks on swap

* fix quote for D recalc

* sync function

* remove liquidity from private pool

* fix order tokens on private factory

* D as view

* fix natspec

* clean up add liquidity

* calcSwap and getToken helper views

* separate D view

* fee and deadline check

* private factory interface

* private pool interface

* natspec for factory fns

* init priv factory tests, add mocks

* test private factory

* test private pool constructor

* test quote in private pool

* test setSwapFee in private pool

* test views in private pool

* test addLiquidity positives

* test addLiquidity when reverts

* test removeLiquidity success cases

* test removeLiquidity revert cases

* test calculateSwap

* fix calculateSwap to check same token index

* test swap success cases

* test swap revert cases

* hasQuote modifier to check price

* rm init of fees array in swap

* calculateSwap should zero and not revert

* fix swap for erc20 transfer fee

* mock token with fee

* test swap with token fee

* removeLiquidityOneToken consistent with stableswap approach

* fix removeLiquidity to take in amounts

* remove minToMint and Burn

* fix stale comment

* fix RemoveLiquidity event

* fix addLiquidity for nonstandard ERC20 transfer

* fix removeLiquidity for nonstandard transfer, add reentrancy guard

* fix private factory interface

* remove ownable in private factory

* clean up pool swap comments

* admin fee sent on pool swap

* test factory set admin fee

* test factory set owner

* accumulated admin fees on private pool

* test pool setAdminFee

* fix calculate swap with balance transfers

* explicit revert if not pool in factory

* recipient emit... (continued)

207 of 1394 branches covered (14.85%)

Branch coverage included in aggregate %.

151 of 151 new or added lines in 2 files covered. (100.0%)

664 of 3094 relevant lines covered (21.46%)

22.15 hits per line