Yoast / PHPUnit-Polyfills / 5189064520
96%
3.x: 98%

LAST BUILD BRANCH: 4.x
DEFAULT BRANCH: 3.x
Ran
Jobs 20
Files 37
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
5189064520

push

github

jrfnl 
Tests: fail test runs on deprecations/notices/warnings

As this package is used in the CI pipeline for other packages, it is important for this package to be ready for new PHP releases _early_, so failing the test suite on deprecations/notices and warnings is appropriate.

Apparently PHPUnit 10.0 already included a `failOnWarning` option, while PHPUnit 10.1 brings additional `failOnNotice` and `failOnDeprecation` options.

Unfortunately, these options are problematic for cross-version PHPUnit usage for the following reasons:
1. They do not translate to the same behaviour between PHPUnit < 10 and PHPUnit 10.x.
    In PHPUnit 9.x, the `convertDeprecationsToExceptions` and sister-options would only act on PHP native deprecations/notices/warnings and would cause a failed build with a non-zero exit code when set to `true` and any PHP deprecations/notices/warnings would be found.
    In PHPUnit 10.x, the `failOnWarning` and sister-options act on **_all_** deprecations/notices/warnings, not just the PHP native ones, and cause a failed build with a non-zero exit code when set to `true`.
    In practice, this means that when the `failOn*` options are used, PHPUnit native deprecations/notices/warnings will now also fail a build, which was not the case in PHPUnit < 10.
2. As the XML file is validated against the XSD file, this means that you cannot add the `failOnNotice`/`failOnDeprecation` options in a configuration file which will be used on PHPUnit 10.0 as that would fail the XSD validation, leading to a PHPUnit warning which would fail the build.
3. Along the same lines, as the `include`/`exclude` elements within the `coverage` element are deprecated as of PHPUnit 10.1, in favour of using `source` with `include`/`exclude`, a configuration which validates on PHPUnit 10.0 will not validate correctly on PHPUnit 10.1 leading to a deprecation notice, which would fail the build when `failOnDeprecation` is on.
... etc...

This basically means that if you want PHPUn... (continued)

359 of 373 relevant lines covered (96.25%)

116.07 hits per line

Jobs
ID Job ID Ran Files Coverage
1 php-7.3-phpunit-auto - 5189064520.1 37
39.95
 GitHub Action Run
2 php-8.1-phpunit-auto - 5189064520.2 37
5.26
 GitHub Action Run
3 php-8.2-phpunit-10.1.0 - 5189064520.3 37
5.26
 GitHub Action Run
4 php-7.0-phpunit-auto - 5189064520.4 37
76.92
 GitHub Action Run
5 php-8.2-phpunit-auto - 5189064520.5 37
5.26
 GitHub Action Run
6 php-5.6-phpunit-auto - 5189064520.6 37
78.15
 GitHub Action Run
7 php-8.1-phpunit-9.3.0 - 5189064520.7 37
55.98
 GitHub Action Run
8 php-7.3-phpunit-7.2.7 - 5189064520.8 37
77.59
 GitHub Action Run
9 php-5.6-phpunit-5.7.21 - 5189064520.9 37
78.15
 GitHub Action Run
10 php-8.0-phpunit-auto - 5189064520.10 37
38.76
 GitHub Action Run
11 php-8.1-phpunit-10.0.12 - 5189064520.11 37
16.75
 GitHub Action Run
12 php-8.0-phpunit-9.3.0 - 5189064520.12 37
55.98
 GitHub Action Run
13 php-7.2-phpunit-6.3.1 - 5189064520.13 37
78.01
 GitHub Action Run
14 php-7.1-phpunit-5.7.21 - 5189064520.14 37
77.55
 GitHub Action Run
15 php-7.2-phpunit-auto - 5189064520.15 37
55.06
 GitHub Action Run
16 php-7.1-phpunit-auto - 5189064520.16 37
58.42
 GitHub Action Run
17 php-7.4-phpunit-auto - 5189064520.17 37
39.95
 GitHub Action Run
18 php-7.4-phpunit-8.1.6 - 5189064520.18 37
59.11
 GitHub Action Run
19 php-7.0-phpunit-5.7.27 - 5189064520.19 37
77.55
 GitHub Action Run
20 php-8.2-phpunit-9.3.0 - 5189064520.20 37
55.98
 GitHub Action Run
Source Files on build 5189064520