• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

uber / tchannel-go / 1754
85%
dev: 88%

Build:
Build:
LAST BUILD BRANCH: delayed_frame_alloc
DEFAULT BRANCH: dev
Ran 04 May 2016 10:13PM UTC
Jobs 4
Files 40
Run time 28min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1754

push

travis-ci

prashantv
Use glide instead of godep to manage dependencies

Glide is cleaner to use, and separates the version we want vs the commit
hash that we're locked to.

In our Makefile, we don't use the vendor directory, but install
dependencies to the GOPATH. This keeps it compatible with go1.4, but the
goal was not for compatibility. This was required because of thrift-gen
tests. thrift-gen tests build Thrift generated code to a temporary
directory, which references the tchannel/thrift package. If we use the
vendor directory, the tchanne/thrift package references the vendored
version of Apache's thrift library, and the generated code references
the non-vendored version fo the dependencies. This leads to errors like:

  *S1M1Args does not implement "github.com/uber/tchannel-go/vendor/github.com/apache/thrift/lib/go/thrift".TStruct (wrong type for Read method)
          have Read("github.com/apache/thrift/lib/go/thrift".TProtocol) error
          want Read("github.com/uber/tchannel-go/vendor/github.com/apache/thrift/lib/go/thrift".TProtocol) error

The fix it to not use the vendor directory when running tests.

3327 of 3915 relevant lines covered (84.98%)

10329.91 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
3
100.0
connection.go
4
100.0
peer.go
Jobs
ID Job ID Ran Files Coverage
1 1754.1 (TEST_TIMEOUT_SCALE=20) 04 May 2016 10:41PM UTC 0
84.7
Travis Job 1754.1
2 1754.2 (TEST_TIMEOUT_SCALE=20) 04 May 2016 10:13PM UTC 0
84.72
Travis Job 1754.2
3 1754.3 (TEST_TIMEOUT_SCALE=20) 04 May 2016 10:13PM UTC 0
84.79
Travis Job 1754.3
4 1754.4 (TEST_TIMEOUT_SCALE=20) 04 May 2016 10:13PM UTC 0
84.55
Travis Job 1754.4
Source Files on build 1754
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1754
  • 200e957b on github
  • Prev Build on glide (#1752)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc