1754
85%
dev: 88%

Ran 04 May 2016 10:13PM UTC

Jobs 4

Files 40

Run time 28min

Badge

Embed ▾

pending completion

Build # 1754

Build Type

push

travis-ci

Committed by

prashantv

Commit Message

Use glide instead of godep to manage dependencies

Glide is cleaner to use, and separates the version we want vs the commit
hash that we're locked to.

In our Makefile, we don't use the vendor directory, but install
dependencies to the GOPATH. This keeps it compatible with go1.4, but the
goal was not for compatibility. This was required because of thrift-gen
tests. thrift-gen tests build Thrift generated code to a temporary
directory, which references the tchannel/thrift package. If we use the
vendor directory, the tchanne/thrift package references the vendored
version of Apache's thrift library, and the generated code references
the non-vendored version fo the dependencies. This leads to errors like:

  *S1M1Args does not implement "github.com/uber/tchannel-go/vendor/github.com/apache/thrift/lib/go/thrift".TStruct (wrong type for Read method)
          have Read("github.com/apache/thrift/lib/go/thrift".TProtocol) error
          want Read("github.com/uber/tchannel-go/vendor/github.com/apache/thrift/lib/go/thrift".TProtocol) error

The fix it to not use the vendor directory when running tests.

Run Details

3327 of 3915 relevant lines covered (84.98%)

10329.91 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	80.73	-0.55%	connection.go
4	89.4	-1.32%	peer.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	1754.1 (TEST_TIMEOUT_SCALE=20)	04 May 2016 10:41PM UTC	40	84.7	Travis Job 1754.1
2	1754.2 (TEST_TIMEOUT_SCALE=20)	04 May 2016 10:13PM UTC	40	84.72	Travis Job 1754.2
3	1754.3 (TEST_TIMEOUT_SCALE=20)	04 May 2016 10:13PM UTC	40	84.79	Travis Job 1754.3
4	1754.4 (TEST_TIMEOUT_SCALE=20)	04 May 2016 10:13PM UTC	40	84.55	Travis Job 1754.4

Source Files on build 1754

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

uber / tchannel-go / 1754
85%
dev: 88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1754

uber / tchannel-go / 1754 85% dev: 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 1754

uber / tchannel-go / 1754
85%
dev: 88%

README BADGES
x