decentraland / marketplace-favorites-server / 5144022441

90%

Build Type

push

github

Committed by web-flow

Commit Message

feat: Adding/Removing item to/from lists in bulk endpoint (#143)

* refactor: Move item exists validation above

* refactor: Generalize item exists validations & insert VP query

* feat: Pick & Unpick in bulk endpoint

* feat: Tests, fixes, and applied feedback from PR

* Update test/unit/picks-handler.spec.ts

Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com>

* Update test/unit/lists-component.spec.ts

Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>
Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com>

* refactor: Check if the VP is undefined to do nothing on conflict

* refactor: Avoid typeof comparisson

---------

Signed-off-by: Kevin Szuchet <31735779+kevinszuchet@users.noreply.github.com>
Co-authored-by: Lautaro Petaccio <1120791+LautaroPetaccio@users.noreply.github.com>

Run Details

323 of 356 branches covered (90.73%)

Branch coverage included in aggregate %.

89 of 92 new or added lines in 11 files covered. (96.74%)

1 existing line in 1 file now uncovered.

640 of 700 relevant lines covered (91.43%)

7.27 hits per line