grafana / django-saml2-auth / 5110979655

91%

master: 90%

push

github

login page redirect url passed as RelayState instead of "login_next_url" (#164)

* login page redirect url passed as RelayState instead of "login_next_url

I am using MS-AAD, for admin urls such as https://dns/admin/django_celery_beat/periodictask/, I enforce login first.
After login, next url is always assigned to default url as code over here.

next_url = request.session.get("login_next_url") or get_default_next_url()

After login, its POST request to acs where new session gets created so request.session.get("login_next_url") is always None.
However I observed that in such cases next_url is passed as relay_state.

So to keep existing behaviour and fix the problem, assigning next_url to relay_state if it's None

* Added test case for acs view
* Test cases for https://github.com/grafana/django-saml2-auth/issues/165
* Incorporated review comments, added extra check to verify relay state is not a token
* using magicmock to avoid test failures
* adding space to avoid flake8 error

38 of 38 new or added lines in 2 files covered. (100.0%)

854 of 951 relevant lines covered (89.8%)

12.54 hits per line