• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

grafana / django-saml2-auth / 5110979655
91%
master: 90%

Build:
Build:
LAST BUILD BRANCH: renovate/mypy-1.x
DEFAULT BRANCH: master
Ran 29 May 2023 10:29AM UTC
Jobs 14
Files 13
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
5110979655

push

github

web-flow
login page redirect url passed as RelayState instead of "login_next_url" (#164)

* login page redirect url passed as RelayState instead of "login_next_url

I am using MS-AAD, for admin urls such as https://dns/admin/django_celery_beat/periodictask/, I enforce login first.
After login, next url is always assigned to default url as code over here.

next_url = request.session.get("login_next_url") or get_default_next_url()

After login, its POST request to acs where new session gets created so request.session.get("login_next_url") is always None.
However I observed that in such cases next_url is passed as relay_state.

So to keep existing behaviour and fix the problem, assigning next_url to relay_state if it's None

* Added test case for acs view
* Test cases for https://github.com/grafana/django-saml2-auth/issues/165
* Incorporated review comments, added extra check to verify relay state is not a token
* using magicmock to avoid test failures
* adding space to avoid flake8 error

38 of 38 new or added lines in 2 files covered. (100.0%)

854 of 951 relevant lines covered (89.8%)

12.54 hits per line

Jobs
ID Job ID Ran Files Coverage
1 5110979655.1 29 May 2023 10:29AM UTC 0
89.64
GitHub Action Run
2 5110979655.2 29 May 2023 10:29AM UTC 0
89.64
GitHub Action Run
3 5110979655.3 29 May 2023 10:29AM UTC 0
89.54
GitHub Action Run
4 5110979655.4 29 May 2023 10:29AM UTC 0
89.54
GitHub Action Run
5 5110979655.5 29 May 2023 10:29AM UTC 0
89.54
GitHub Action Run
6 5110979655.6 29 May 2023 10:29AM UTC 0
89.64
GitHub Action Run
7 5110979655.7 29 May 2023 10:29AM UTC 0
89.54
GitHub Action Run
8 5110979655.8 29 May 2023 10:29AM UTC 0
89.85
GitHub Action Run
9 5110979655.9 29 May 2023 10:29AM UTC 0
89.48
GitHub Action Run
10 5110979655.10 29 May 2023 10:29AM UTC 0
89.54
GitHub Action Run
11 5110979655.11 29 May 2023 10:29AM UTC 0
89.75
GitHub Action Run
12 5110979655.12 29 May 2023 10:29AM UTC 0
89.75
GitHub Action Run
13 5110979655.13 29 May 2023 10:29AM UTC 0
89.7
GitHub Action Run
14 5110979655.14 29 May 2023 10:29AM UTC 0
89.54
GitHub Action Run
Source Files on build 5110979655
Detailed source file information is not available for this build.
  • Back to Repo
  • 6b82bb94 on github
  • Prev Build on main (#3895061166)
  • Next Build on main (#5111267836)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc