2456
59%

Ran 01 May 2016 08:54PM UTC

Jobs 1

Files 33

Run time 2s

Badge

Embed ▾

pending completion

Build # 2456

Build Type

Pull #1306

travis-ci

Committed by

mdorman

Commit Message

Fix logic for running cabal directly.

I suspect this has been broken for a while (perhaps always).  The
failure stems from the fact that (haskell-interactive-process) throws an
uncaught error if there is no interacive process, which aborts the
function.  If that is wrapped to mask the error, (process-status child)
also throws an uncaught error, which aborts the function.

Thus the direct cabal invocation code would never be reached.

This is the least intrusive fix I can see---wrapping both calls
with (ignore-errors), and not even checking (process-status) if we don't
have a process.  In manual testing it behaves as expected, running
`cabal build`.

A more extensive fix---which would rewrite the conditional logic to wrap
all the dangerous bits in a single (ignore-errors)---would almost
certainly swap positions of the indirect cabal invocation and the direct
cabal invocation, so there would be much more churn.  Still, it might
produce a nicer overall result, if anyone wants to see that.

Pull Request Pull Request #1306: Fix logic for running cabal directly.

Run Details

2091 of 6981 relevant lines covered (29.95%)

94.52 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2456.1 (EMACS=emacs24 TARGET=check)	01 May 2016 08:54PM UTC	33	29.95	Travis Job 2456.1

Source Files on build 2456

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

haskell / haskell-mode / 2456
59%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2456

haskell / haskell-mode / 2456 59%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2456

haskell / haskell-mode / 2456
59%

README BADGES
x