eaburns / T / 1385
89%
master: 88%

LAST BUILD BRANCH: gofont
DEFAULT BRANCH: master
Ran
Jobs 1
Files 21
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1385

push

travis-ci

eaburns 
re1: simplify matching machine.

 1. Use slices instead of linked lists.
 2. Share the same structure for queues and the stack.
 3. Don't bother caching pre-created machines in the Regexp itself.

1 and 2 only give a very slight performance hit.

3 gives a performance hit in the benchmark (see below). It makes reusing a compiled expression slower, because the machine needs to be allocated each time. However, T will never reuse compiled Regexps, so it wasn't worth the complexity.

Comparing ec242fc (old) to this commit (new).
benchmark                            old ns/op      new ns/op       delta
BenchmarkRegexpMatchEasy0x32-4       1006           1864            +85.29%
BenchmarkRegexpMatchEasy0x1K-4       14054          15945           +13.46%
BenchmarkRegexpMatchEasy0x1M-4       15614534       15764265        +0.96%
BenchmarkRegexpMatchEasy0x32M-4      483182028      506561267       +4.84%
BenchmarkRegexpMatchEasy1x32-4       1005           1473            +46.57%
BenchmarkRegexpMatchEasy1x1K-4       13939          14976           +7.44%
BenchmarkRegexpMatchEasy1x1M-4       15305797       17401075        +13.69%
BenchmarkRegexpMatchEasy1x32M-4      485285880      560910244       +15.58%
BenchmarkRegexpMatchMediumx32-4      579            1149            +98.45%
BenchmarkRegexpMatchMediumx1K-4      21085          25177           +19.41%
BenchmarkRegexpMatchMediumx1M-4      22250088       25806742        +15.98%
BenchmarkRegexpMatchMediumx32M-4     713769856      822719072       +15.26%
BenchmarkRegexpMatchHardx32-4        12295          13450           +9.39%
BenchmarkRegexpMatchHardx1K-4        246438         369973          +50.13%
BenchmarkRegexpMatchHardx1M-4        247631755      389203919       +57.17%
BenchmarkRegexpMatchHardx32M-4       8041883218     12154456267     +51.14%

benchmark                            old MB/s     new MB/s     speedup
BenchmarkRegexpMatchEasy0x32-4       31.80        17.16        0.54x
BenchmarkRegexpMatchEasy0x1K-4       72.86        64.22        0.88x
BenchmarkRegexpMatchEasy0x1M-4       67.15        66.52        0.99x
BenchmarkRegexpMatchEasy0x32M-4      69.44        66.24        0.95x
BenchmarkRegexpMatchEasy1x32-4       31.84        21.71        0.68x
BenchmarkRegexpMatchEasy1x1K-4       73.46        68.37        0.93x
BenchmarkRegexpMatchEasy1x1M-4       68.51        60.26        0.88x
BenchmarkRegexpMatchEasy1x32M-4      69.14        59.82        0.87x
BenchmarkRegexpMatchMediumx32-4      1.73         0.87         0.50x
BenchmarkRegexpMatchMediumx1K-4      48.56        40.67        0.84x
BenchmarkRegexpMatchMediumx1M-4      47.13        40.63        0.86x
BenchmarkRegexpMatchMediumx32M-4     47.01        40.78        0.87x
BenchmarkRegexpMatchHardx32-4        2.60         2.38         0.92x
BenchmarkRegexpMatchHardx1K-4        4.16         2.77         0.67x
BenchmarkRegexpMatchHardx1M-4        4.23         2.69         0.64x
BenchmarkRegexpMatchHardx32M-4       4.17         2.76         0.66x

4391 of 4938 relevant lines covered (88.92%)

2.03 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1385.1 (PATH=$HOME/gopath/bin:$PATH) 0
88.92
 Travis Job 1385.1
Source Files on build 1385
Detailed source file information is not available for this build.