luci / gae / 151

82%

push

travis-ci

filter/txnBuf: Use fully-qualified App ID.

Use the fully-qualified app ID when creating the in-memory datastore for
transaction buffer. Previously, transaction buffer would use the
standard App ID, while production datastore would use the
fully-qualified App ID, causing key incompatibility errors in
production.

Cleanup impl/memory's NewDatastore function to not install superfluous
services into the Context. This draws a cleaner line between
impl/memory's dual purposes as both a rich testing enviornment and a
production-grade in-memory datastore.

In addition, have impl/memory's info service differentiate between the
two. This causes tests for filter/txnBuf to properly fail lacking this
fix, enabling regression protection.

To support this, impl/memory's Info service will now parse the supplied
App ID. If it contains a "~" character, it is split into fully-qualified
and regular AppID. Otherwise, the two will be the same.

BUG=

Review-Url: https://codereview.chromium.org/1929423002

24 of 24 new or added lines in 4 files covered. (100.0%)

6565 of 8022 relevant lines covered (81.84%)

1277.64 hits per line