gugod / Hijk / 122

91%

master: 92%

Build Type

push

travis-ci

Committed by borislav nikolov

Commit Message

use non-blocking socket; decrease timeout after io

switching to non-blocking sockets solved:

* at the moment we use select() -> read() on blocking socket,
  sometimes however select() might give a socket to io from
  and the io operation will block

* we were always blocking on write(), which is of course problem
  if the connection succeeds, that does not mean that the write
  wont block

decrease timeout:
* there was an issue with 'read(), wait, read(), wait' scenarios
  where the timeout was always the same, so in theory it might
  lead to unexpectedly long request() calls.

  this requires Time::HiRes::CLOCK_MONOTONIC() which guarantees
  that the time value will always move forward (meaning it
  wont be messed up by time set for example), so we can simply
  do:
    $timeout -= $start - $clock();
  so every IO operation's wait time is decremented from the
  original timeout value

Run Details

40 of 40 new or added lines in 1 file covered. (100.0%)

268 of 296 relevant lines covered (90.54%)

219.94 hits per line