2640
51%

Ran 26 Apr 2016 10:37AM UTC

Jobs 3

Files 296

Run time 3min

Badge

Embed ▾

pending completion

Build # 2640

Build Type

push

travis-ci

Committed by

mhl

Commit Message

On merging / reverting remove Memberships as well as MembershipExtras

This was a bug - the revert_person_from_version_data method,
which was used to implement merges of two candidates as well
as reverting them to an earlier version, deletes all existing
candidacies of a person and then recreates the ones that
should be there.  However, the code was only actually removing
the MembershipExtra objects and leaving the Membership objects
in the database.  These weren't shown on the user-facing site
because of missing the MembershipExtra objects, but would be
shown in the API output which was causing confusion.

This commit fixes that problem; a delete on the Membership
queryset deletes the corresponding MembershipExtras too.

Thanks to Sym Roe (@symroe) for spotting this and figuring
out that it related to merging.

Run Details

7054 of 9524 relevant lines covered (74.07%)

2.22 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	2640.1	26 Apr 2016 10:37AM UTC	74.07	Travis Job 2640.1
2	2640.2	26 Apr 2016 10:40AM UTC	74.07	Travis Job 2640.2
3	2640.3	26 Apr 2016 10:41AM UTC	74.07	Travis Job 2640.3

Source Files on build 2640

Detailed source file information is not available for this build.

mysociety / yournextrepresentative / 2640
51%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2640

mysociety / yournextrepresentative / 2640 51%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2640

mysociety / yournextrepresentative / 2640
51%

README BADGES
x