• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

luci / gae / 145
82%

Build:
DEFAULT BRANCH: master
Ran 22 Apr 2016 04:33PM UTC
Jobs 1
Files 74
Run time 6s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
145

push

travis-ci

Commit bot
Fix memory corruption bug in impl/memory

When you `SetCollection` in gkvlite, it invalidates the old
collection, but keeps the Items of the previous collection. The way
that impl/memory was using SetCollection was more along the lines of
GetOrCreate, which could cause corruption or other issues if two
codepaths did SetCollection simultaneously.

This fixes the corruption bug by removing SetCollection from the
memStore interface and replaces it with a GetOrCreateCollection,
which checks for the collection, and only calls SetCollection if it
doesn't exist. As a bonus, this seems to give a slight performance
speedup over the previous broken code.

Additionally, this forces all uses of VisitItemsAscend to use
a Snapshot, to avoid accidental modification of a Collection while
its being iterated over, which can lead to the situation discussed
above, or other nasty errors.

Finally, this adds an optional 'gkvlite tracer' functionality
which came in (extremely) handy for finding this bug. When given
a folder, it will emit go-code-like invocations of the functions run
on every collection, and includes enough information to reveal which
functions are being called on the root collection v. snapshots, and
if there are any overlapping VisitItemsAscend invocations, etc.

R=dnj@chromium.org
BUG=550684

Review URL: https://codereview.chromium.org/1911263002

211 of 211 new or added lines in 8 files covered. (100.0%)

6498 of 7957 relevant lines covered (81.66%)

1287.4 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
impl/memory/datastore.go
1
100.0
impl/memory/datastore_data.go
1
100.0
impl/memory/gkvlite_iter.go
10
100.0
impl/memory/gkvlite_utils.go
116
100.0
impl/memory/gkvlite_tracing_utils.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
impl/memory/datastore_index_selection.go
Jobs
ID Job ID Ran Files Coverage
1 145.1 22 Apr 2016 04:33PM UTC 0
81.66
Travis Job 145.1
Source Files on build 145
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #145
  • e6d5b594 on github
  • Prev Build on master (#144)
  • Next Build on master (#146)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc