• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Valloric / ycmd / 1851
94%

Build:
DEFAULT BRANCH: master
Ran 21 Apr 2016 10:25PM UTC
Jobs 1
Files 40
Run time 6min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1851

push

travis-ci

homu
Auto merge of #463 - micbou:index-error, r=Valloric

[READY] Definitely fix IndexError exception from C++

PR #453 did not completely fix the IndexError issue, but moved it to other parts of the C++ code. The exception is now raised by the [`NodeListForLetter` method in `QueryMatchResult`](https://github.com/Valloric/ycmd/blob/master/cpp/ycm/Candidate.cpp#L96) when the query contains non-ascii characters. Since we don't support this kind of query, we want to deal with it as early as possible: in the `CandidatesForQueryAndType` and `FilterAndSortCandidates` functions. We don't check for non-ascii characters but for nonprintable ones as [we already do for candidates](https://github.com/Valloric/ycmd/blob/master/cpp/ycm/CandidateRepository.cpp#L136).

Added two tests for the `CandidatesForQuery` function: `EmptyCandidatesForUnicode` is failing without this PR but not `EmptyCandidatesForNonPrintable` because nonprintable candidates are ignored.

No tests for `FilterAndSortCandidates` because it will be tested by the Python layer in PR #455.

Core version bumped.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/463)
<!-- Reviewable:end -->

2976 of 3519 relevant lines covered (84.57%)

0.85 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1851.1 (USE_CLANG_COMPLETER=true YCMD_PYTHON_VERSION=2.7 COVERAGE=true) 21 Apr 2016 10:25PM UTC 0
84.57
Travis Job 1851.1
Source Files on build 1851
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1851
  • 30a45249 on github
  • Prev Build on master (#1845)
  • Next Build on master (#1857)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc