#1075
93%

Ran 09 Mar 2023 09:58PM UTC

Jobs 1

Files 78

Run time 2s

Badge

Embed ▾

pending completion

Build # #1075

Build Type

push

github-actions

Committed by

web-flow

Commit Message

JSpecify generics checks for conditional expressions (#739)

For a conditional expression _e_, the type parameter nullability annotations of the true-subpart and false-subpart should match the annotations required by _e_'s context.  E.g., if _e_ is the right-hand side of an assignment, the annotations should match those for the type parameters for the assignment's left-hand side:
```java
// this is fine
A<@Nullable String> t = condition? new A<@Nullable String> : new A<@Nullable String>();
// this is bad
A<@Nullable String> t2 = condition? new A<String> : new A<String>();
// this is also bad
A<@Nullable String>  t1 = condition ? new A<String>(): new A<@Nullable String>()
```
Other contexts include returns, parameter passing, and being nested inside another conditional expression.  In our experience, it seems that `javac` captures the type parameter nullability required by _e_'s context in the type of _e_ itself.  So, our handling of conditional expressions simply checks that the types of both the true and false sub-expressions of _e_ are assignable to (i.e., a subtype of) the type of _e_, using the same machinery for checking assignments from #715.

Run Details

5476 of 5880 relevant lines covered (93.13%)

0.93 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
6	96.86	0.41%	../nullaway/src/main/java/com/uber/nullaway/GenericsChecks.java
14	96.15	0.01%	../nullaway/src/main/java/com/uber/nullaway/NullAway.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#1075.1	09 Mar 2023 09:58PM UTC	78	93.13

uber / NullAway / #1075
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #1075

uber / NullAway / #1075 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build #1075

uber / NullAway / #1075
93%

README BADGES
x