Galbar / JsonPath-PHP / #16

99%

push

Review issue 37: Added test cases with expected results

I reviewed the list of cases listed in the issue. Some of them were
indeed bugs, some others I considered that the current behaviour is the
expected one.

Specifically:
- empty results are considered "no match" and thus return `false`
- Fixed a bug that allowed dot-notation to accept variable names
  starting with numbers. This implementation only accepts valid
  JavaScript variable names with the dot-notation. Use the bracket
  notation otherwise.
- Fixed the case when querying for `$[?(@.key<42)]` in `{"some":
  "value"}` would return ["value"]. This happened because `@.key` would
  return false and PHP would compare `false < 42`. The fix makes sure
  that a comparisson between a boolean and a non-boolean always returns
  false.

2 of 2 new or added lines in 1 file covered. (100.0%)

394 of 397 relevant lines covered (99.24%)

41.93 hits per line