1384
79%
master: 5%

Ran 11 Apr 2016 08:25PM UTC

Jobs 3

Files 92

Run time 3min

Badge

Embed ▾

pending completion

Build # 1384

Build Type

push

travis-ci

Committed by

josephharrington

Commit Message

Verify slave session id on is_alive check

Previously when the master checked if a slave is alive, it only
checked if the slave service is responsive at that url. This change
makes the master also verify that the slave service that responds at
that url still has the same session id that the slave reported when
it connected to the master.

This will cause the `slave.is_alive()` check on the master to start
returning false if the slave responds but has the wrong session id.
Previously this would return true.

This is done by setting a header in the master's request to the
slave that includes the expected session id. If the slave sees this
and it does not match its current session id, it will return a 412
and the master will consider the slave with the old session id to be
offline.

This fixes #296. Now when the slave allocator does the `is_alive()`
call before allocating a slave to a build, it will correctly detect
when a slave's session id has changed and should be considered
offline.

Run Details

2919 of 3694 relevant lines covered (79.02%)

0.83 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1384.1 (TARGETS="lint test-unit-with-coverage")	11 Apr 2016 08:26PM UTC	77.02	Travis Job 1384.1
2	1384.2 (TARGETS="test-integration-with-coverage")	11 Apr 2016 08:25PM UTC	5.68	Travis Job 1384.2
3	1384.3 (TARGETS="test-functional test-unit-via-clusterrunner")	11 Apr 2016 08:28PM UTC		Travis Job 1384.3

Source Files on build 1384

Detailed source file information is not available for this build.

box / ClusterRunner / 1384
79%
master: 5%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1384

box / ClusterRunner / 1384 79% master: 5%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1384

box / ClusterRunner / 1384
79%
master: 5%

README BADGES
x