Robpol86 / colorclass / 415

100%

push

travis-ci

<a href="https://github.com/Robpol86/colorclass/commit/<a class=hub.com/Robpol86/colorclass/commit/bfc41be0e22a1e2331b280ede4dff3446e40a2f8">bfc41be0e<a href="https://github.com/Robpol86/colorclass/commit/bfc41be0e22a1e2331b280ede4dff3446e40a2f8">&quot;&gt;Fixed long-standing Windows bug.

Embarrassingly this was broken for over a year (broken in
</a><a class="double-link" href="https://github.com/Robpol86/colorclass/commit/<a class="double-link" href="https://github.com/Robpol86/colorclass/commit/88a0149bec04b8a20e0cc375b5d1e45b609c1d39">88a0149be</a>">88a0149be</a><a href="https://github.com/Robpol86/colorclass/commit/bfc41be0e22a1e2331b280ede4dff3446e40a2f8">). Bug caused colors to now show
up on Windows, just bare text with no ANSI codes.

The cause was WindowsStreamStdOut/Err class variables were defined on
module load-time, and they read class variable values of WindowsCSBI
which at load-time were None. Only during WindowsStreamStdOut/Err
instantiation were WindowsCSBI class variables defined, but
WindowsStreamStdOut/Err did not re-read the values. Hence they were
always None, and Windows code didn&#39;t know which stream handle to write
to.

Fixes https://github.com/Robpol86/colorclass/issues/17.

495 of 502 relevant lines covered (98.61%)

0.99 hits per line