PulpQE / pulp-smash / 421
63%

DEFAULT BRANCH: master
Ran
Jobs 3
Files 6
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
421

push

travis-ci

Ichimonji10 
Increase task polling timeout

When Pulp Smash receives an HTTP 202 "accepted" response from Pulp, it
polls each of the spawned tasks and waits for them to complete. (This is
the default behaviour.) Pulp Smash gives each individual task roughly
two minutes to complete before timing out and raising a
`TaskTimedOutError`. Timing out in this manner has value: we don't want
to let a single misbehaved task to block the test suite from executing,
and if a single task takes excessively long, this can be considered a
bug in its own right.

Unfortunately, real world test results show that a wide variety of tasks
occasionally take longer than two minutes. The failures occur at a low
rate, but are widely spread through the test suite. In one especially
bad test run, five of roughly eighty test cases failed.

There are at least two ways to deal with time-outs. One is to expand the
`poll_task` and `poll_spawned_tasks` methods, and make it possible to
specify a time-out when calling the method. For example:

    poll_spawned_tasks(server_config, call_report, timeout)

This is a good solution if we have a task or series of tasks that we
know will be especially long running. For example, if we ask Pulp to
calculate content applicability for ten hosts, we will want to extend
the timeout for that one series of tasks.

Another solution is to extend the default time-out for all task polling.
This latter solution has risks, as can be gleaned from the first
paragraph of this commit message. However, it is more appropriate if the
default time-out is too short in a wide variety of cases.

Extend the default timeout from two to three minutes.

302 of 411 relevant lines covered (73.48%)

2.2 hits per line

Jobs
ID Job ID Ran Files Coverage
1 421.1 0
73.48
 Travis Job 421.1
2 421.2 0
73.48
 Travis Job 421.2
3 421.3 0
73.48
 Travis Job 421.3
Source Files on build 421
Detailed source file information is not available for this build.