m-lab / go / 1226

96%

push

travis-ci-com

Adds funcs to return strings w/ prefixes and suffixes (#158)

* Adds funcs to return strings w/ prefixes and suffixes

Previously, the only string function returned a typical mlab hostname.
This commit adds additional string functions to return various
combinations of the hostname with or without prefixes and suffixes.

Additionally, this commit modifies the v2 regexp to capture and return
an prefix. Previously the prefix match was a non-capturing group.

* Renames Prefix to Service + PR feedback changes

* Fixes String functions + adds more unit tests

I realized that some of the String* functions would return bad hostnames
in the event that certain fields were not present in the input hostname.
This commit should fix that.

Also, this commit adds unit tests for the new String* functions to be
sure they are doing what we expect.

* Simplifies the String function, reusing existing functionality

25 of 25 new or added lines in 1 file covered. (100.0%)

2169 of 2296 relevant lines covered (94.47%)

162.41 hits per line