421
78%

Ran 04 Apr 2016 09:26PM UTC

Jobs 1

Files 21

Run time 1174min

Badge

Embed ▾

pending completion

Build # 421

Build Type

Pull #21

travis-ci

Committed by

jwilm

Commit Message

Add support for PING frame

The protocol specifies a few things that could not be handled here due
to current Solicit APIs.

> If a PING frame is received with a stream identifier field value other
> than 0x0, the recipient MUST respond with a connection error (Section
> 5.4.1) of type PROTOCOL_ERROR.

and

> Receipt of a PING frame with a length field value other than 8 MUST be
> treated as a connection error (Section 5.4.1) of type
> FRAME_SIZE_ERROR.

When receiving a PING frame without the ACK flag set, the connection
replies with a PING frame having the ACK flag set. When an ACK is
received, nothing is done.

In addition to supporting the PING frame of the HTTP/2 protocol, a
method is exposed on the Async client to support sending PINGs as
desired by the client. This part of the feature is a bit half-baked as
the client has no way of getting the PONG. It wasn't clear how this
API should work. At the very least, it provides a method which will send
PING frames and return an error immediately if the client isn't capable
of making requests.

Pull Request Pull Request #21: Add support for PING frame

Run Details

2882 of 3077 relevant lines covered (93.66%)

0.94 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
3	98.29	0.0%	http/frame/mod.rs
4	86.03	-1.94%	http/transport.rs
12	94.83	0.0%	http/session.rs
12	89.8	-2.35%	http/tests/common.rs
13	88.79	-4.0%	http/client/mod.rs
19	89.95	-1.81%	client/async.rs
31	89.63	-3.72%	http/connection.rs

Jobs

ID	Job ID	Ran	Files	Coverage
3	421.3	05 Apr 2016 04:55PM UTC	21	93.66	Travis Job 421.3

Source Files on build 421

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

mlalic / solicit / 421
78%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 421

mlalic / solicit / 421 78%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 421

mlalic / solicit / 421
78%

README BADGES
x