pennersr / django-allauth / 465

96%

main: 96%

Pull #555

travis-ci

<a href="https://github.com/pennersr/django-allauth/commit/<a class=hub.com/pennersr/django-allauth/commit/af687e31efaf6aea598d9cd121d0070c29f89849">af687e31e<a href="https://github.com/pennersr/django-allauth/commit/af687e31efaf6aea598d9cd121d0070c29f89849">&quot;&gt;Don&amp;#39;t call self.load() from registry.register() to avoid recursion.

Presently registry.load() imports provider modules, and each module
calls registry.register(), which itself calls self.load().  The result is
that self.load() attempts to import the entire list of modules once for
each provider module that calls registry.register().

The recursion doesn&amp;#39;t hurt because already-imported modules don&amp;#39;t run
again, but it would be better to avoid it, and there&amp;#39;s no reason for
registry.register() to call self.load()

commit </a><a class="double-link" href="https://github.com/pennersr/django-allauth/commit/<a class="double-link" href="https://github.com/pennersr/django-allauth/commit/b19fad7921a7a0106c7a93f6d684d86471750364">b19fad792</a>">b19fad792</a><a href="https://github.com/pennersr/django-allauth/commit/af687e31efaf6aea598d9cd121d0070c29f89849">
Author: Aron Griffis &lt;aron@arongriffis.com&gt;
Date:   Mon Mar 3 19:00:44 2014 -0500

    Don&#39;t

diff --git a/allauth/socialaccount/providers/__init__.py b/allauth/socialaccount/providers/__init__.py
index fde92d1..d30141a 100644
--- a/allauth/socialaccount/providers/__init__.py
+++ b/allauth/socialaccount/providers/__init__.py
@@ -11,7 +11,6 @@ class ProviderRegistry(object):
         return self.provider_map.values()

     def register(self, cls):
-        self.load()
         self.provider_map[cls.id] = cls()

     def by_id(self, id):

3995 of 4557 relevant lines covered (87.67%)

5.03 hits per line