#1042
93%

Ran 26 Jan 2023 05:39PM UTC

Jobs 1

Files 78

Run time 4s

Badge

Embed ▾

pending completion

Build # #1042

Build Type

push

github-actions

Committed by

web-flow

Commit Message

Ignore incompatibly annotated var args from Kotlin code. (#721)

See #720 for a detailed explanation.

Long story short: 

1. `kotlinc` will add `@org.jetbrains.annotations.NotNull` as a declaration annotation for any argument that is non-null, which we pick up from jars when running with `AcknowledgeRestrictiveAnnotations=true`. 
2. Unfortunately, it will mark code such as `open fun w(vararg args: Any?)` as having `@NotNull args` (meaning the array itself). 
3. This is indistinguishable at the bytecode level from Java code such as  `w(@NotNull Object... args)`, which we believe should be interpreted as marking the elements of `args` as being `@NotNull`.
4. This PR hacks `RestrictiveAnnotationHandler` to skip `@org.jetbrains.annotations.NotNull` on var args only.

Additionally, our basic handling of var args is pretty broken. I went over our test cases and commented where I think our current behavior is different from the desired behavior as documented in #720 and #674. Foregoing fixing it for now, as I am worried about the breaking change and I think we want to avoid changing that before 0.10.9.

Run Details

5281 of 5677 relevant lines covered (93.02%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	#1042.1	26 Jan 2023 05:39PM UTC	0	93.02

Source Files on build #1042

Detailed source file information is not available for this build.

uber / NullAway / #1042
93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #1042

uber / NullAway / #1042 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build #1042

uber / NullAway / #1042
93%

README BADGES
x