133
96%

Ran 02 Mar 2014 07:46AM UTC

Jobs 10

Files 21

Run time –

Badge

Embed ▾

pending completion

Build # 133

Build Type

push

travis-ci

Committed by

Bouke

Commit Message

Set an error code for phone_number_validator.

phone_number_validator works well when validating from a model, but not
so well when validating from a form field. It uses the default code of
"invalid," which the Django fields will map to a pre-defined error
message, ignoring the custom one given by the validator.

By setting a custom error code, this mapping won't happen, and the
validator's message will instead be used.

Unit tests were added to test the validator on a custom form (where the
problem appears), and on PhoneSetupView (where it does not, but the test
will ensure it never breaks without noticing).

Run Details

635 of 641 relevant lines covered (99.06%)

9.87 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	133.1 (DJANGO_VERSION=1.4.10)	02 Mar 2014 07:47AM UTC	99.06	Travis Job 133.1
2	133.2 (DJANGO_VERSION=1.5.5)	02 Mar 2014 07:46AM UTC	99.06	Travis Job 133.2
3	133.3 (DJANGO_VERSION=1.6)	02 Mar 2014 07:47AM UTC	99.06	Travis Job 133.3
4	133.4 (DJANGO_VERSION=1.4.10)	02 Mar 2014 07:46AM UTC	99.06	Travis Job 133.4
5	133.5 (DJANGO_VERSION=1.5.5)	02 Mar 2014 07:46AM UTC	99.06	Travis Job 133.5
6	133.6 (DJANGO_VERSION=1.6)	02 Mar 2014 07:48AM UTC	99.06	Travis Job 133.6
7	133.7 (DJANGO_VERSION=1.5.5)	02 Mar 2014 07:48AM UTC	98.13	Travis Job 133.7
8	133.8 (DJANGO_VERSION=1.6)	02 Mar 2014 07:48AM UTC	98.13	Travis Job 133.8
9	133.9 (DJANGO_VERSION=1.5.5)	02 Mar 2014 07:48AM UTC	98.13	Travis Job 133.9
10	133.10 (DJANGO_VERSION=1.6)	02 Mar 2014 07:48AM UTC	98.13	Travis Job 133.10

Source Files on build 133

Detailed source file information is not available for this build.

Bouke / django-two-factor-auth / 133
96%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 133

Bouke / django-two-factor-auth / 133 96%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 133

Bouke / django-two-factor-auth / 133
96%

README BADGES
x