uber / NullAway / #1026
93%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 77
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
#1026

push

github-actions

web-flow 
Resolve regression for type annotations directly on inner types. (#706)

This resolves #705 by broadening our slightly overzealous filtering from #702.

We still want to filter type use annotations out when they happen on wildcards or
type parameters. However, we can handle annotations on inner types (i.e. `Foo.@Nullable Bar`).
More importantly, these inner types appear implicitly in natural code involving inner classes,
such as:

```
class Bar {
   @Nullable Foo foo; // <- this is, implicitly Bar.@Nullable Foo !!
   class Foo { }
}
```

Not handling this case leads to confusing an unintuitive errors where a `@Nullable` annotation
with a type use location will seemingly stop working for certain fields at random, if those fields
are of an inner type.

Additionally, as part of this fix, we restore the handling of type use annotations at the start of
an array type as meaning the array object itself is `@Nullable` (i.e. `@Nullable Foo[] arr`, in
addition to the correct type use form `Foo @Nullable[] arr`). This is technically incorrect, but
prohibiting it would break backwards compatibility with older versions of NullAway and surprise
users, specially those switching from declaration annotations to type use annotations.

See #708 for a full discussion of the tradeoffs and the path forward towards the proper semantics
for type use annotations.

Co-authored-by: Manu Sridharan <msridhar@gmail.com>

5191 of 5582 relevant lines covered (93.0%)

0.93 hits per line

Jobs
ID Job ID Ran Files Coverage
1 #1026.1 0
93.0
Source Files on build #1026
Detailed source file information is not available for this build.